Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider signing by KeyPair reference not by value #4199

Closed
Arjentix opened this issue Jan 12, 2024 · 2 comments
Closed

Consider signing by KeyPair reference not by value #4199

Arjentix opened this issue Jan 12, 2024 · 2 comments
Assignees
@Arjentix
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Refactor Improvement to overall code quality

Comments

@Arjentix
Copy link
Contributor

Related fixme:

iroha/genesis/src/lib.rs

Lines 63 to 69 in a3fad9b

raw_transaction
// FIXME: fix underlying chain of `.sign` so that it doesn't
// consume the key pair unnecessarily. It might be costly to clone
// the key pair for a large genesis.
.sign(genesis_key_pair.clone())
.map(GenesisTransaction)
.wrap_err_with(|| eyre!("Failed to sign transaction at index {i}"))

Also see this discussion: #4181 (comment)
@Arjentix Arjentix added iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality Optimization Something isn't working as well as it should labels Jan 12, 2024
@Arjentix Arjentix mentioned this issue Jan 12, 2024
Merged
5 tasks
Arjentix added a commit to Arjentix/iroha that referenced this issue Jan 29, 2024
@Arjentix
[refactor] hyperledger#4199: Sign by reference
179715e 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Jan 31, 2024
@Arjentix
[refactor] hyperledger#4199: Sign by reference
9b78ee0 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
Arjentix added a commit to Arjentix/iroha that referenced this issue Jan 31, 2024
@Arjentix
[refactor] hyperledger#4199: Sign by reference
fca3e04 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit to Arjentix/iroha that referenced this issue Feb 6, 2024
@Arjentix @mversic
[refactor] hyperledger#4199: Sign by reference
4fc4c01 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
mversic pushed a commit that referenced this issue Feb 6, 2024
@Arjentix
[refactor] #4045: Use concrete key types (#4181)
e5ad44a 
* [refactor] #4045: Use concrete key types

* [feature]: Allow `iroha_crypto` in WASM

* [refactor]: Replace amcl_wrapper with w3f-bls

* [refactor]: Hide random key generation under feature flag

* [ci]: Fix docker compose consistency check

* [refactor]: Remove `Box` from `PrivateKey`

* [refactor] #4199: Sign by reference

* [refactor]: Reduce key size with Box

---------

Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@Arjentix Arjentix self-assigned this Feb 13, 2024
@Arjentix
Copy link
Contributor Author

Resolved by #4181

@Arjentix Arjentix reopened this Feb 13, 2024
@mversic
Copy link
Contributor

mversic commented Oct 10, 2024

was finished

@mversic mversic closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arjentix Arjentix

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arjentix @mversic