Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] (de-)serialize PrivateKey with algorithm field #4287

Closed
0x009922 opened this issue Feb 18, 2024 · 0 comments
Closed

[suggestion] (de-)serialize PrivateKey with algorithm field #4287

0x009922 opened this issue Feb 18, 2024 · 0 comments
Assignees
@0x009922
Labels
config-changes Changes in configuration and start up of the Iroha crypto good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@0x009922
Copy link
Contributor

iroha_crypto::PrivateKey serialized form contains digest_function and payload fields:

[private_key]
digest_function = "ed25519"
payload = "8f4c15e5d664da3f13778801d23d4e89b76e94c1b94b389544168b6cb894f84f8ba62848cf767d72e7f7f4b9d2d7ba07fee33760f79abe5597a51520e292a0cb"

I propose rename it to algorithm, to be concise and to reflect internal representation:

[private_key]
algorithm = "ed25519"
payload = "8f4c15e5d664da3f13778801d23d4e89b76e94c1b94b389544168b6cb894f84f8ba62848cf767d72e7f7f4b9d2d7ba07fee33760f79abe5597a51520e292a0cb"
@0x009922 0x009922 added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST config-changes Changes in configuration and start up of the Iroha crypto labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@0x009922 0x009922 self-assigned this Feb 26, 2024
@0x009922 0x009922 mentioned this issue Feb 26, 2024
Merged
0x009922 added a commit that referenced this issue Feb 27, 2024
@0x009922
[fix] #4287: use algorithm in PrivateKey serialized form (#4326)
fe2b301 
* [rename]: rename `digest` and `digest_function` to `algorithm`

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>

* [chore]: "fix" format

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>

---------

Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x009922 0x009922

Labels
config-changes Changes in configuration and start up of the Iroha crypto good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0x009922