Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Use nonzero_ext across workspace #4289

Closed
0x009922 opened this issue Feb 18, 2024 · 1 comment
Closed

[suggestion] Use nonzero_ext across workspace #4289

0x009922 opened this issue Feb 18, 2024 · 1 comment
Assignees
@nxsaken
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@0x009922
Copy link
Contributor

#4239 introduced nonzero_ext dependency in iroha_config. @mversic suggested that it might be a good idea to use it all across the workspace.
@0x009922 0x009922 added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@nxsaken nxsaken self-assigned this Apr 3, 2024
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 3, 2024
@nxsaken
[refactor] hyperledger#4289: Use nonzero! instead of fallible NonZe…
39bc315 
…ro* constructors

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 3, 2024
@nxsaken
[refactor] hyperledger#4289: Use nonzero! instead of fallible NonZe…
61b5834 
…ro* constructors

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken nxsaken mentioned this issue Apr 3, 2024
Merged
5 tasks
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 3, 2024
@nxsaken
[refactor] hyperledger#4289: Use nonzero! instead of fallible NonZe…
07d8a17 
…ro* constructors

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 3, 2024
@nxsaken
[refactor] hyperledger#4289: Disable std in nonzero_ext
d35bcdf 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 3, 2024
@nxsaken
[refactor] hyperledger#4289: Use nonzero! in integration tests
9f39a88 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
nxsaken added a commit that referenced this issue Apr 3, 2024
@nxsaken
[refactor] #4289: Use nonzero! instead of fallible NonZero* constru…
fee1cfc 
…ctors (#4402)

[refactor] #4289: Use `nonzero!` instead of fallible NonZero* constructors
[refactor] #4289: Disable `std` in `nonzero_ext` 
[refactor] #4289: Use `nonzero!` in integration tests

Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken
Copy link
Contributor

nxsaken commented Apr 3, 2024

Done via #4402.

@nxsaken nxsaken closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nxsaken nxsaken

Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nxsaken @0x009922