Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[suggestion] Remove parse_display dependency entirely #4290

Closed
0x009922 opened this issue Feb 18, 2024 · 1 comment
Closed

[suggestion] Remove parse_display dependency entirely #4290

0x009922 opened this issue Feb 18, 2024 · 1 comment
Assignees
@nxsaken
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality

Comments

@0x009922
Copy link
Contributor

In #4239 @mversic suggested to remove parse_display dependency entirely from the workspace. At the moment it is used by iroha_ffi_derive:

iroha/ffi/derive/Cargo.toml

Line 27 in df8c49a

parse-display = "0.8.2"

There are other crates, like strum and serde_with, that we usually rely on instead.
@0x009922 0x009922 added good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality labels Feb 18, 2024
This was referenced Feb 18, 2024
Merged
Closed
@nxsaken nxsaken self-assigned this Apr 2, 2024
nxsaken added a commit to nxsaken/iroha that referenced this issue Apr 2, 2024
@nxsaken
[refactor] hyperledger#4290: Replace parse_display crate with strum
ad48484 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken nxsaken mentioned this issue Apr 2, 2024
Merged
5 tasks
nxsaken added a commit that referenced this issue Apr 3, 2024
@nxsaken
[refactor] #4290: Replace parse_display crate with strum (#4401)
172769c 
Signed-off-by: Nurzhan Sakén <nurzhan.sakenov@gmail.com>
@nxsaken
Copy link
Contributor

nxsaken commented Apr 3, 2024

Done via #4401.

@nxsaken nxsaken closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nxsaken nxsaken

Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST Refactor Improvement to overall code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nxsaken @0x009922