Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log level fix #1486

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Log level fix #1486

merged 1 commit into from
Sep 29, 2021

Conversation

i1i1
Copy link

@i1i1 i1i1 commented Sep 29, 2021

Description of the Change

closes #1484

Fix display of logs with log level less than info.

Issue

Beforehand maximum log level withing tracing was set to INFO, now we override it with minimum.

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 29, 2021
@i1i1 i1i1 force-pushed the log-fixup branch 2 times, most recently from dcdeca6 to 7a955e1 Compare September 29, 2021 14:29
iroha_logger/src/lib.rs Show resolved Hide resolved
iroha_logger/src/lib.rs Show resolved Hide resolved
e-ivkov
e-ivkov previously approved these changes Sep 29, 2021
Signed-off-by: i1i1 <vanyarybin1@live.ru>
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #1486 (dcdeca6) into iroha2-dev (73c3185) will increase coverage by 1.22%.
The diff coverage is 74.28%.

❗ Current head dcdeca6 differs from pull request most recent head 7d0bbdc. Consider uploading reports for the commit 7d0bbdc to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1486      +/-   ##
==============================================
+ Coverage       75.07%   76.30%   +1.22%     
==============================================
  Files             111      112       +1     
  Lines           17451    17559     +108     
==============================================
+ Hits            13102    13398     +296     
+ Misses           4349     4161     -188     
Impacted Files Coverage Δ
iroha/test_network/tests/sumeragi_with_mock.rs 0.24% <0.00%> (-0.02%) ⬇️
iroha_client/src/client.rs 76.71% <50.00%> (+13.27%) ⬆️
iroha_client/src/http_client.rs 91.48% <80.48%> (+20.52%) ⬆️
iroha/src/queue.rs 98.11% <100.00%> (+3.25%) ⬆️
iroha/src/sumeragi/mod.rs 93.12% <100.00%> (+0.67%) ⬆️
iroha/src/torii/mod.rs 87.37% <100.00%> (+1.75%) ⬆️
...a_client/tests/tests/multisignature_transaction.rs 100.00% <100.00%> (+100.00%) ⬆️
iroha_logger/src/lib.rs 78.12% <100.00%> (+1.45%) ⬆️
iroha_logger/tests/log_level.rs 100.00% <100.00%> (ø)
iroha_actor/src/lib.rs 81.55% <0.00%> (-0.65%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b459d4e...7d0bbdc. Read the comment docs.

@i1i1 i1i1 merged commit 8ddaf0b into hyperledger:iroha2-dev Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants