Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check that authority owns domain to transfer #4807

Merged
merged 1 commit into from
Jul 8, 2024
Merged

fix: Check that authority owns domain to transfer #4807

merged 1 commit into from
Jul 8, 2024

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jul 5, 2024

Description

When transfer domain from source account:

  • Fixed check in executor that authority owns domain (previously it checked that source owns domain, but it is not needed since it is checked in iroha_core)
  • Improved error message for check that source owns domain in iroha_core

Linked issue

Closes #4751

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jul 5, 2024
@dima74 dima74 force-pushed the diralik/fix-domain-transfer branch from 838240f to b713197 Compare July 5, 2024 15:08
nxsaken
nxsaken previously approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@nxsaken nxsaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nits from me

client/tests/integration/transfer_domain.rs Outdated Show resolved Hide resolved
client/tests/integration/transfer_domain.rs Outdated Show resolved Hide resolved
@dima74 dima74 force-pushed the diralik/fix-domain-transfer branch from b713197 to 062711e Compare July 5, 2024 15:41
@dima74
fix: Check that authority owns domain to transfer
60fa87b 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
@dima74 dima74 force-pushed the diralik/fix-domain-transfer branch from 6a33d63 to 60fa87b Compare July 8, 2024 08:03
@dima74 dima74 merged commit 9174001 into hyperledger:main Jul 8, 2024
10 of 11 checks passed
@dima74 dima74 deleted the diralik/fix-domain-transfer branch July 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@mversic mversic mversic approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

@nxsaken nxsaken

@mversic mversic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Domain transfer can be performed by anyone
3 participants
@dima74 @nxsaken @mversic