refactor!: rename wasm to smart contract #4810
Conversation
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
| Executable::Instructions(instructions) => tx_builder.with_instructions(instructions), | ||
| Executable::Wasm(wasm) => tx_builder.with_wasm(wasm), | ||
| Executable::SmartContract(smart_contract) => { |
There was a problem hiding this comment.
Imo what corresponds to smartcontracts is triggers in Iroha, and the executable part of a trigger (and a transaction) can be Wasm or ISIs. So I don't think "smartcontract" is a good candidate to rename "wasm"
There was a problem hiding this comment.
While working on #4850, I noticed that Iroha has both triggers and smart contracts, at least we have two separate macros for defining the entry point. Not sure what the difference is.
There was a problem hiding this comment.
Ok, so smart contracts only have an owner, but triggers also specify the trigger id, owner and event. What happens when a trigger wasm is executed as a smart contract, and vice versa?
There was a problem hiding this comment.
While working on #4850, I noticed that Iroha has both triggers and smart contracts, at least we have two separate macros for defining the entry point. Not sure what the difference is.
how I see it.
Transaction::executableis either aVec<Instruction>orSmartContract
You can execute an executable withclient.submit. This executes the instructions or the smart contract immediately on submitionAction::executableis either aVec<Instruction>orSmartContract
You have to first register a trigger and then invoke it withInstructionBox::Execute. The trigger can consist ofVec<InstructinoBox> or a be a smart contract
There was a problem hiding this comment.
Ok, so smart contracts only have an owner, but triggers also specify the trigger id, owner and event
no, smart contracts don't have an owner. The transaction they are part of has an owner
There was a problem hiding this comment.
I mean a smart contract entrypoint has an owner param, while a trigger entrypoint has that plus additional params
mversic
force-pushed
the
rename_wasm
branch
3 times, most recently
from
4db1839
to
05e47ec
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
|
@s8sato has a good point. I'm closing this |
Description
The fact that we work with wasm smart contracts is a sort of implementation detail.
Let's not specify implementation details in the API.
Linked issue
Closes #{issue_number}
Benefits
If we change from wasm to some other VM, we will have a reduced effect on the API.
If we don't it is implied that we use wasm, so no harm done there
Checklist
CONTRIBUTING.md