Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URN parsing #21

Merged
merged 6 commits into from
Dec 22, 2015
Merged

Fix URN parsing #21

merged 6 commits into from
Dec 22, 2015

Conversation

vadymmarkov
Copy link
Contributor

@zenangst

  1. Add expectations to tests, they didn't work properly because we have closures, so we didn't see some of them actually weren't passing.
  2. Back to the condition we had before Fix URL or URI condition logic #20, prefix couldn't have query as a prefix, because prefix is a part of the route, so it's a part of the query as well.
  3. Fix guard condition for URL parsing.

@vadymmarkov
Copy link
Contributor Author

screen shot 2015-12-22 at 14 40 28

@vadymmarkov
Copy link
Contributor Author

@zenangst I'm gonna merge it because this thingy is kinda blocking me at the moment 😄 Just write if you don't agree with something here.

vadymmarkov added a commit that referenced this pull request Dec 22, 2015
@vadymmarkov vadymmarkov merged commit 905003b into master Dec 22, 2015
@vadymmarkov vadymmarkov deleted the fix/urn-condition branch December 22, 2015 13:59
@zenangst
Copy link
Contributor

🤔😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants