-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compass 3.0.0 #33
Merged
Merged
Compass 3.0.0 #33
Changes from 18 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
fe10b45
Return route instead of completion closure
vadymmarkov 134bd5f
Update tests
vadymmarkov 3fd3b67
Add string extensions
vadymmarkov 374293c
Don't use Sugar
vadymmarkov 2cadf50
Remove references of Sugar
vadymmarkov 758ac16
Share compass navigate
vadymmarkov 8347a0c
Share router and routable
vadymmarkov a239346
Move files around
vadymmarkov ff13057
Refactor tests
vadymmarkov 7dd6779
Re-structure project
vadymmarkov f1bfccb
Rename to identifier
vadymmarkov 5c0b57e
Rename to location
vadymmarkov c1bdcd6
Move files around again
vadymmarkov c631de2
Update tests
vadymmarkov 1f4a8f9
Update readme
vadymmarkov e752d19
Reconfigure travis
vadymmarkov f78f607
Fix linting
vadymmarkov 6d69265
Update podspec
vadymmarkov 76d6af0
3.0.0
vadymmarkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"maxReviewers": 2, | ||
"requiredOrgs": ["hyperoslo"] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
included: | ||
- Sources | ||
excluded: | ||
- Carthage | ||
- Pods | ||
- Packages | ||
opt_in_rules: | ||
- empty_count | ||
disabled_rules: | ||
- valid_docs | ||
force_cast: warning | ||
force_try: | ||
severity: warning | ||
line_length: 120 | ||
function_body_length: | ||
- 150 | ||
type_body_length: | ||
warning: 300 | ||
error: 400 | ||
file_length: | ||
warning: 500 | ||
error: 1200 | ||
type_name: | ||
min_length: 3 | ||
max_length: | ||
warning: 40 | ||
error: 50 | ||
variable_name: | ||
min_length: 2 | ||
reporter: "xcode" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
os: | ||
- osx | ||
osx_image: xcode7.3 | ||
language: objective-c | ||
|
||
before_install: | ||
- brew update | ||
- if brew outdated | grep -qx xctool; then brew upgrade xctool; fi | ||
- carthage update --platform iOS,Mac | ||
|
||
install: | ||
- if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then ./swiftlint.sh; fi | ||
script: | ||
- xctool clean build -project Compass.xcodeproj -scheme Compass-iOS -sdk iphonesimulator | ||
- xctool test -project Compass.xcodeproj -scheme Compass-iOS -sdk iphonesimulator | ||
- xctool clean build -project Compass.xcodeproj -scheme Compass-Mac -sdk macosx | ||
- xctool test -project Compass.xcodeproj -scheme Compass-Mac -sdk macosx | ||
- xcodebuild clean build -project Compass.xcodeproj -scheme Compass-iOS -sdk iphonesimulator | ||
- xcodebuild test -project Compass.xcodeproj -scheme Compass-iOS -sdk iphonesimulator | ||
- xcodebuild clean build -project Compass.xcodeproj -scheme Compass-Mac -sdk macosx | ||
- xcodebuild test -project Compass.xcodeproj -scheme Compass-Mac -sdk macosx | ||
notifications: | ||
email: false |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can reduce to just
s.source_files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍