-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: location payload #34
Conversation
|
|
Yeah I'm totally for |
@zenangst |
This is good 🎉 |
@onmyway133 |
@onmyway133 any suggestions? otherwise I'll just go ahead and merge this bad-boi |
@zenangst I think you can go ahead |
AAAA YEAH! |
@zenangst @onmyway133 @RamonGilabert
Mappable
like in Feature: mappable meta Brick#12 it addsTailor
as a dependency and could lead to many small struct types in the project codebase. My solution here is to add a new property onLocation
:Since it's
Any
we can pass whatever we want and then cast it to the type that we expect:payload
property, do we needfragments
at all? Because you can set[String: AnyObject]
dictionary as payload. The only disadvantage is that you have to cast it later:Routable
that will be caught inRouter
and handled by a new type calledErrorRoutable
. It means we can present some error screen when the route is not found or arguments are invalid.