Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoding urn #45

Merged
merged 3 commits into from
Jan 30, 2017
Merged

Encoding urn #45

merged 3 commits into from
Jan 30, 2017

Conversation

onmyway133
Copy link
Contributor

This adds support for escaping urn string.

  • Encode urn when constructing url for parsing
  • Decode urn when accessing arguments on Location

@onmyway133 onmyway133 changed the title Fix/url encoding Encoding urn Jan 30, 2017
@vadymmarkov vadymmarkov merged commit a63bd9c into master Jan 30, 2017
@vadymmarkov vadymmarkov deleted the fix/url_encoding branch January 30, 2017 11:52
@vadymmarkov
Copy link
Contributor

@onmyway133 Great stuff!

@zenangst
Copy link
Contributor

@onmyway133 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenangst zenangst Awaiting requested review from zenangst

@vadymmarkov vadymmarkov Awaiting requested review from vadymmarkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onmyway133 @vadymmarkov @zenangst