Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigate using Navigator #52

Merged
merged 2 commits into from
Aug 16, 2017
Merged

Navigate using Navigator #52

merged 2 commits into from
Aug 16, 2017

Conversation

onmyway133
Copy link
Contributor

  • Add some handy methods on Navigator, to help navigating easier
  • Use Navigator.handle to handle location request, this way we promote 1 single place to handle location request. If user uses UIApplicationDelegate openUrl to url scheme routing, we can redirect to this Navigator.handle too

@mention-bot
Copy link

@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zenangst to be a potential reviewer.

zenangst
zenangst approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@zenangst zenangst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@onmyway133 onmyway133 merged commit 07dc8ff into master Aug 16, 2017
@onmyway133 onmyway133 deleted the fix/navigator branch August 16, 2017 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zenangst zenangst zenangst approved these changes

@vadymmarkov vadymmarkov Awaiting requested review from vadymmarkov

@JohnSundell JohnSundell Awaiting requested review from JohnSundell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onmyway133 @mention-bot @zenangst