Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Deactivated DIDs are not allowed to update. #354

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

arnabghose997
Copy link
Contributor

This PR fixes the Update DID RPC by adding a check to ensure Deactivated DIDs are not allowed to update. Necessary tests have been added.

@arnabghose997 arnabghose997 added bug Something isn't working ssi labels Apr 21, 2023
@arnabghose997 arnabghose997 self-assigned this Apr 21, 2023
Copy link
Contributor

@Vishwas1 Vishwas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean testcase was not written for this case?

@arnabghose997 arnabghose997 merged commit b943ffc into develop Apr 21, 2023
@arnabghose997 arnabghose997 deleted the bugfix-update-did branch April 21, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ssi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants