Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imageio 2.28 #106

Merged
merged 5 commits into from
Apr 25, 2023
Merged

Fix imageio 2.28 #106

merged 5 commits into from
Apr 25, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Apr 24, 2023

It seems latest imageio release (2.28) mixed their API version: the legacy is using the new API for the pillow.

Pin again python-box to >=6,<7 until it is fixed.

Progress of the PR

  • Migrate to imageio.v3,
  • [n/a] update docstring (if appropriate),
  • [n/a] update user guide (if appropriate),
  • add an changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting changelog entry in the readthedocs doc build of this PR (link in github checks)
  • update tests,
  • ready for review.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.68 🎉

Comparison is base (0ca8be4) 84.19% compared to head (c864f83) 84.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   84.19%   84.87%   +0.68%     
==========================================
  Files          73       73              
  Lines        8927     8928       +1     
  Branches     1962     1962              
==========================================
+ Hits         7516     7578      +62     
+ Misses        946      884      -62     
- Partials      465      466       +1     
Impacted Files Coverage Δ
rsciio/image/_api.py 91.11% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rsciio/tests/test_image.py Fixed Show fixed Hide fixed
rsciio/tests/test_image.py Outdated Show resolved Hide resolved
rsciio/tests/test_image.py Outdated Show resolved Hide resolved
@jlaehne
Copy link
Contributor

jlaehne commented Apr 25, 2023

looks good, just don't know what you mean with 'new newer'

@jlaehne jlaehne added this to the v0.1.0 initial release milestone Apr 25, 2023
@ericpre
Copy link
Member Author

ericpre commented Apr 25, 2023

It was a typo: "needs newer"!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants