-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up packaging #125
Merged
Merged
Clean up packaging #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 85.24% 85.00% -0.25%
==========================================
Files 73 73
Lines 9042 9054 +12
Branches 2046 2049 +3
==========================================
- Hits 7708 7696 -12
- Misses 872 892 +20
- Partials 462 466 +4
☔ View full report in Codecov by Sentry. |
jlaehne
reviewed
May 27, 2023
ericpre
force-pushed
the
clean_up_packaging
branch
from
May 28, 2023 06:44
5ea1015
to
cc7c950
Compare
…t.toml. `setup.py` is now only used to build c extension using `setuptools
ericpre
force-pushed
the
clean_up_packaging
branch
from
May 31, 2023 18:41
8458266
to
85d089e
Compare
ericpre
force-pushed
the
clean_up_packaging
branch
from
May 31, 2023 19:10
85d089e
to
716863e
Compare
jlaehne
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping in draft for now, as it would be to get #123 merged first.
Progress of the PR
pyproject.toml
and keepsetup.py
to compile c extensionMANIFEST.in
. andpyproject.toml
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)