Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POOCH_BASE_URL to specify the base url used by pooch to download test data #200

Merged
merged 4 commits into from
Dec 17, 2023

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Dec 13, 2023

This will fix the package_and_test.yml workflow after adding some files in a PR (see for example #162 (comment)) and also the release.yml workflow when running from a fork for testing the workflow (it is current working fine for a "real" run because the tag is then available in the hyperspy/rosettasciio repository).
I though it would be more complicated to fix and possibly not worth making something complicated but this solution is actually very simple.

Progress of the PR

  • Add POOCH_BASE_URL to specify the base url used by pooch to download test data,
  • [n/a] update docstring (if appropriate),
  • update user guide (if appropriate),
  • add a changelog entry in the upcoming_changes folder (see upcoming_changes/README.rst),
  • Check formatting of the changelog entry (and eventual user guide changes) in the docs/readthedocs.org:rosettasciio build of this PR (link in github checks)
  • add tests,
  • ready for review.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0052ce) 86.25% compared to head (9e936c9) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.02%     
==========================================
  Files          82       82              
  Lines       10541    10544       +3     
  Branches     2291     2291              
==========================================
+ Hits         9092     9093       +1     
- Misses        931      933       +2     
  Partials      518      518              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ericpre ericpre force-pushed the add_environment_variable_pooch branch from 261ca59 to 9e162a7 Compare December 13, 2023 16:14
@ericpre ericpre force-pushed the add_environment_variable_pooch branch 4 times, most recently from 01a57ca to 4c0cfb7 Compare December 17, 2023 11:42
@ericpre ericpre force-pushed the add_environment_variable_pooch branch from 4c0cfb7 to 9e936c9 Compare December 17, 2023 12:03
@ericpre
Copy link
Member Author

ericpre commented Dec 17, 2023

For reference, I had to fiddle with finding the correct github context variable for push and pull_request event, which is not very from the github documentation but actually event payload can viewed as documented in https://docs.github.com/en/webhooks/testing-and-troubleshooting-webhooks/viewing-webhook-deliveries.

@ericpre ericpre merged commit 3210042 into hyperspy:main Dec 17, 2023
30 of 31 checks passed
@ericpre ericpre added this to the v0.4 milestone Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants