Fix codeql warning and web links #74
Conversation
Codecov ReportBase: 84.27% // Head: 84.26% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 84.27% 84.26% -0.01%
==========================================
Files 65 65
Lines 8481 8482 +1
Branches 1894 1894
==========================================
Hits 7147 7147
- Misses 875 876 +1
Partials 459 459
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ericpre
force-pushed
the
fix_codeql_warning
branch
from
7d0480c
to
a216166
Compare
ericpre
force-pushed
the
fix_codeql_warning
branch
from
a216166
to
277cb79
Compare
| @@ -179,8 +182,7 @@ | |||
| if _UREG.Quantity(units).check("1/[length]"): | |||
| scalebar_kwds["dimension"] = "si-length-reciprocal" | |||
|
|
|||
| scalebar = ScaleBar(axis["scale"], units, **scalebar_kwds) | |||
| ax.add_artist(scalebar) | |||
| ax.add_artist(ScaleBar(axis["scale"], units, **scalebar_kwds)) | |||
Check failure
Code scanning / CodeQL
Potentially uninitialized local variable
There was a problem hiding this comment.
I have dismissed this CodeQL failure for the following reason:
Python is case sensitive: in this case, we have class name (ScaleBar, camel case) which "clashes" with the keyword argument (scalebar, all lower case). We could use an alias for the import of the class name but I don't think that this is worth it.
Follow up of #72.
Progress of the PR
upcoming_changesfolder (seeupcoming_changes/README.rst),readthedocsdoc build of this PR (link in github checks)