Add support for 3.11 and 3.12 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
reviewed
Oct 21, 2024
| exporter = ZipkinExporter( | ||
| endpoint=self._config.agent_config.reporting.endpoint | ||
| ) | ||
| #exporter = ZipkinExporter( |
There was a problem hiding this comment.
will this give some form of npe? Maybe we can make this case point to noopexporter?
There was a problem hiding this comment.
no npe here. We assign exporter to None by default & then the caller of this func checks:
exporter = self._init_exporter(reporter_type)
if exporter is None:
logger.warning("Unable to initialize exporter")
return
varkey98
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently python otel zipkin has conflicting proto dependency as otlp http, for now I've commented out zipkin support(we still have otlp http & otlp grpc)