Avoid unintended garbage collection of raw data in PreparedDictionaryImpl #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test case as well? I know this is complicated but you can create GC pressure to trigger GC collection. |
|
Good point! The GC pressure seems to do the trick for the test. It consistently fails on the old code but works on the updated code. |
hyperxpro
changed the title
hyperxpro
approved these changes
Nov 27, 2024
|
Thanks a lot! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As described in #189 the garbage collection currently removes the data from the dictionary, resulting in poor compression ratios, since no dictionary was actually used.
The code to finalize the rawData already exists.
Modification:
Hold the reference on rawData in PreparedDictionaryImpl
Result:
Fixes #189.