Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/show extra info in a day cell #242

Conversation

charithAmila
Copy link

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

New feature for show extra information in a day cell.

Related Issue: n/a

@Falkyouall
Copy link

uhmm, is this feature getting merged someday? would be appreciated a lot.

Comment on lines +354 to +355
cellInfo={cellInfo}
cellInfoClassName="abc"
Copy link
Contributor

@kamyar kamyar May 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about instead of passing a list of date & value, passing a function that when it is called with a date, returns the extra info to be shown for it?

@brunolucena
Copy link

Upvote for this PR. I need to build the following UI, with some days marking that something exists in it, and this is really useful.
I'm currently using his version, hope we can see this merged.

image

@kamyar
Copy link
Contributor

kamyar commented Jun 2, 2021

@brunolucena thank you for the input.
I think the feature makes a lot of sense, though I think passing a function would be more maintainable+simpler+performant compared to passing the dataset for each day.
I know some time has passed but @charithAmila do you expect to be able to continue this PR?
Otherwise I will open an issue and maybe try to look into it in the coming weeks.

@kamyar
Copy link
Contributor

kamyar commented Jun 5, 2021

I have opened a PR to achieve this by passing a dayContentRenderer prop that makes it possible to completely customize the DayCell. Can you please take a look and let me know if this looks good?
cc @brunolucena @Falkyouall @charithAmila
#483

@brunolucena
Copy link

@kamyar Thanks a lot, that renderer looks really great, it'll make things a lot easier.

@charithAmila
Copy link
Author

I have opened a PR to achieve this by passing a dayContentRenderer prop that makes it possible to completely customize the DayCell. Can you please take a look and let me know if this looks good?
cc @brunolucena @Falkyouall @charithAmila
#483

Looks grate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants