Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Day Number Color prop to ranges #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DrewVartanian
Copy link

@DrewVartanian DrewVartanian commented Jun 26, 2020

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

Currently, it seems the only way to overwrite the color of the date number text in a range is to use CSS, and any change will be applied to all ranges. This can lead to an issue if someone wants to apply different text colors to different ranges. This can come up when one range's color is very bright, necessitating a dark text color, and one range is very dark, necessitating a bright text color. In addition, it is nice to be able to set the text color with a prop, rather than having to overwrite/modify the default CSS.

This PR adds dayNumberColor as a prop on the ranges object and applies that color to the day number text of any date shown in that range.

Related Issue: #383

@kamyar
Copy link
Contributor

kamyar commented Jun 6, 2021

Hi, can you take a look at #483 and see if it would cover this usecase also?

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants