Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added validation to verify if date in DateInput is between minDate and maxDate #539

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YounesZADI
Copy link

added validation to verify if date in DateInput is between minDate and maxDate

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

In this PR:

  • added verification if the typed date in DateInput is between minDate and MaxDate when editableDateInputs is set to true
  • when date is not valid display a specific message error

Related Issue: 538 (#538)

@YounesZADI
Copy link
Author

Screenshot 2021-12-08 at 11 13 02

This is the expected behaviour

@soundslikeodd
Copy link

This would be a very nice enhancement to have.

Is there any idea on when this might get looked at?

@YounesZADI
Copy link
Author

@burakcan @kamyar @mkg0 any news on this ?

@burakcan
Copy link
Collaborator

burakcan commented Jan 4, 2023

@YounesZADI please see the readme.md and this isse: #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants