Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added data attribute to ignore twitter link, which now throws 400 from CLI #110

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Feb 12, 2021

Re-ticketed from #108 (comment)

See: derat/twittuh#2

Copy link
Contributor

@dcwalk dcwalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh! missed this before, will merge over mine because of slight improvement :)

@dcwalk
Copy link
Contributor

dcwalk commented Feb 13, 2021

Ugh, a new failure that seems flakey--just worked on another PR.

@dcwalk dcwalk merged commit 56c5574 into master Feb 13, 2021
@dcwalk dcwalk deleted the ignore-twitter-links branch February 13, 2021 03:12
@patcon
Copy link
Contributor Author

patcon commented Feb 13, 2021

heh no worries, too many micro-PRs maybe :)

and sometimes links just fail for me, and I re-run and it's good. Just flakey websites. Since we're not in a rush, we could up the timeout for htmlproofer like so: gjtorikian/html-proofer#490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants