CSS parser expression fixes #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's an ID selector, not a general selector. Implementation next...
&& needs to consume all the words *and* all the verifiers. It means the sub-verifiers must all occur, in any order; each may eat zero or more contiguous words. Also note that words can't be null here.
A b expression is just a sequence of numbers separated by 'b''s. It may not include anything else, as is obvious from the verifier method itself. So the old code could incorrectly match 1b2a3b4 as a single b (&&) expression, and then fail in the verifier. Note also that if we use more complex patterns, && binds more strongly than ||, so it would be wrong to allow this even if we could support it.
Similarly, 'a' (||) may only join numbered expressions. This was true until 'b' (&&) was introduced. Simplify the code and make sure it is still true: 1a2a3a4 is a valid || expression, but 1a2b3 is not valid at all, just like 1b2a3.
|
Inconsistant indentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes a bit further than #445. It documents the syntax and limitations and also fixes some potentially confusing bugs in future parsing rules. It is not urgent. CSS tests pass.