-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CurrentTimeUTC #870
Conversation
Thank you for stepping up. Currently the comments do not enable quick replacement. Please try to put yourself in the shoes of someone who wrote a plugin three years ago and since then has only programmed websites with vue or similar. The comment needs to enable them to adjust the code without investigating, otherwise it will never be possible to turn this into deprecation for removal. There are already modified plugins in use. If it’s not trivial (in the strictest sense) to replace the deprecation, removing the deprecated version will still break plugins in the next decade. |
1218e76
to
c91ec6f
Compare
I would not expect plugin developers to need this level of hand-holding in finding alternatives for these (until now mostly undocumented) methods. I've now updated the deprecation notices with verbatim copies of the new implementations provided in #866 to allow for a copy-paste migration path. |
c91ec6f
to
09f1fce
Compare
The Java 8 Date-Time APIs provide superior alternatives for the methods provided in this class.
Only get() and getInMillis() were used within Fred. These methods can trivially be replaced by new Date() and System.currentTimeMillis() respectively.
09f1fce
to
b53b937
Compare
Updated the commits to have GPG signatures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
@bertm merged — thank you! And welcome back! It’s great to see you again ❤️ |
Follow-up on discussion in #866