Remove security lowering kludge. #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the description of this option, if a large portion of the network disables packet padding it makes the network easier to trace. 15 years later now, if network overhead is a real concern for some users they can tweak this themselves.
ArneBab
reviewed
Jan 26, 2024
|
This only removes the code that changes the value despite what the user
selected. The UI option is still valid.
…On Fri, Jan 26, 2024, 3:54 PM Arne Babenhauserheide < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/freenet/node/NodeCryptoConfig.java
<#882 (comment)>:
> @@ -240,18 +240,6 @@ public void set(Boolean val) throws InvalidConfigValueException, NodeNeedRestart
});
paddDataPackets = config.getBoolean("paddDataPackets");
- securityLevels.addNetworkThreatLevelListener(new SecurityLevelListener<NETWORK_THREAT_LEVEL>() {
-
- @OverRide
- public void onChange(NETWORK_THREAT_LEVEL oldLevel, NETWORK_THREAT_LEVEL newLevel) {
- // Might be useful for nodes which are running with a tight bandwidth quota to minimize the overhead,
- // so turn it off for LOW. Otherwise is sensible.
- if(newLevel == NETWORK_THREAT_LEVEL.LOW)
- paddDataPackets = false;
- if(oldLevel == NETWORK_THREAT_LEVEL.LOW)
- paddDataPackets = true;
- }
- });
does this also remove the config option in the UI?
—
Reply to this email directly, view it on GitHub
<#882 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAATAMLJNYJ2LEHZTOLO7U3YQQJXHAVCNFSM6AAAAABBSOD6ISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBWGUZTGOBTGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Oh — you’re right. Since with normal network level the overhead is rarely more than 12%, I agree that we should simply remove this. Thank you! |
|
Merged into next — thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the description of this option, if a large portion of the network disables packet padding it makes the network easier to trace. 15 years later now, if network overhead is a real concern for some users they can tweak this themselves.