Gradle update to 8.9 #977
Gradle update to 8.9 #977
Conversation
baseName → archiveBaseName archiveName → archiveFileName destinationDir → destinationDirectory
build.gradle
Outdated
| testImplementation "org.hamcrest:hamcrest-library:1.3" | ||
| testImplementation "org.hamcrest:hamcrest-core:1.3" | ||
| testImplementation "org.hamcrest:hamcrest:2.2" | ||
| testImplementation "org.hamcrest:hamcrest-core:2.2" |
There was a problem hiding this comment.
These are not the latest versions. junit:junit is at 4.13.2, and org.hamcrest:hamcrest is at 3.0 (and doesn’t need the split libraries anymore).
There was a problem hiding this comment.
I updated junit now, but hamcrest caused problems with validation.
There was a problem hiding this comment.
I updated junit now, but hamcrest caused problems with validation.
testImplementation('junit:junit:4.13.2') {
exclude group: 'org.hamcrest', module: 'hamcrest-core'
}
testImplementation("org.mockito:mockito-core:1.9.5") {
exclude group: 'org.hamcrest', module: 'hamcrest-core'
}
And maybe we should decide at some point which kind of Strings we want to use in build.gradle… 😄
| @@ -213,6 +213,22 @@ | |||
| <sha256 value="90f163f78e3ffb6f1c7ad97de9e7eba4eea25807141b85d6d12be67ca25449c4" origin="Generated by Gradle"/> | |||
| </artifact> | |||
| </component> | |||
| <component group="junit" name="junit" version="4.13"> | |||
| <artifact name="junit-4.13.jar"> | |||
There was a problem hiding this comment.
We don’t need these ones anymore, do we? 🙂
| @@ -250,36 +253,35 @@ dependencies { | |||
| implementation "org.unbescape:unbescape:1.1.6.RELEASE" | |||
| implementation "org.slf4j:slf4j-api:1.7.25" | |||
|
|
|||
| testImplementation 'junit:junit:4.12' | |||
| testImplementation 'junit:junit:4.13.2' | |||
There was a problem hiding this comment.
We do need the exclusions of the old Hamcrest dependencies here; at least on my machine the build fails because it can’t verify hamcrest-core:1.3.
There was a problem hiding this comment.
I restored those for next. thank you!
|
merged — thank you for your reviews! |
this builds on #972