Replace pylint ruff new rules #6773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcospri
force-pushed
the
replace-pylint-ruff
branch
2 times, most recently
from
84fa6ab to
d78de5a
Compare
Merged
marcospri
force-pushed
the
replace-pylint-ruff-new-rules
branch
from
1f414c4 to
83c97f0
Compare
marcospri
force-pushed
the
replace-pylint-ruff
branch
from
d78de5a to
45fa49d
Compare
marcospri
force-pushed
the
replace-pylint-ruff-new-rules
branch
from
83c97f0 to
7ef6d36
Compare
marcospri
force-pushed
the
replace-pylint-ruff-new-rules
branch
from
7ef6d36 to
e57eadd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
This is done mostly as a "proof of concept" of working with ruff. Just the speed itself makes adding tweaking rules much nicer as the feedback loop is instant.
To introduce new rules without big refactor changes (i.e. for new code) you can always use:
ruff check --preview -q lms tests bin --add-noqawhich adds the relevant
noqacomments.If feeling more adventurous some rules also provides fixes that ruff can apply:
ruff check --preview -q lms tests bin --unsafe-fixes --fixI'd like to use this PR to discuss this particular rules and potentially make one PR for each one of them.
More details on the existing rules in ruff: https://docs.astral.sh/ruff/rules/