Gaffer 0.61.1.2 #38
Merged
Gaffer 0.61.1.2 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ericmehl
commented
Jan 18, 2022
ericmehl
commented
- Browsing UNC paths in a file dialog is now supported.
- Fixed regression where scene paths chosen from a path widget or dialog would leave out the leading slash.
- Showing / hiding hidden files are now supported on Windows.
- Inkscape on Windows is likely installed in "C:\Program Files" - the space in the directory name requires quoting to be run
- Arnold stores ai.lib in the `lib` directory - OpenGL uses opengl32 as the library name - Python stores libraries in `libs`
- Opening the file in text mode on Windows generates an error during hashing : "UnicodeDecodeError: 'charmap' codec can't decode byte 0x9d in position 129: character maps to <undefined>"
- override Process::current() check in FileSystemPathPlug
"resource" module is not available on Windows and it appears the best native Python method of getting MaxRSS is through the pywin32 extension which would introduce a new dependency. Using a subprocess command and parsing the output is a simple alternative since performance is not critical here.
- AST is not available on Windows without a patched, customized Python build. - This comes from the experimental implementation in johnhaddon@c817cf6 - Note that it introduces a performance regression for loading scripts vs. the AST implementation.
- Windows does not have `rand_r` function, but `rand` is thread safe, so we use that on Windows only
- Windows uses file attributes to mark files and directories as hidden, so a MatchPatternPathFilter is unsuitable.
…pectiveCamera` - On Windows, IECoreGL does not export `PerspectiveCamera` because it isn't used. This causes an `unresolved external symbol` linker error. - `toGLCameraConverter` only converts to `IECoreGL::Camera`, so this is a safe comparison to make.
- Windows only supports symlinks when the user is an admin or they have enabled developer mode. Most users don't have admin rights, and developer mode has additional implications that may not be desirable. We copy the symlink source when building to ensure the files have the correct content. - Note that builds running on Github workflows are running as admin, so symlinks are correctly made. Testing for the existence of the source file ensures we don't attempt to copy bogus source files.
- Needed for MSVC to see the declaration of `boost::intrusive_ptr_release`
- Solves build error similar to:
- error C3861: 'intrusive_ptr_release': identifier not found
- intrusive_ptr.hpp(98): note: 'intrusive_ptr_release': function was not declared in the template definition context and can be found only via argument-dependent lookup in the instantiation context
- intrusive_ptr.hpp(97): note: while compiling class template member function 'boost::intrusive_ptr<Gaffer::PathFilter>::~intrusive_ptr(void)'
- path.h(76): note: see reference to function template instantiation 'boost::intrusive_ptr<Gaffer::PathFilter>::~intrusive_ptr(void)' being compiled
- path.h(231): note: see reference to class template instantiation 'boost::intrusive_ptr<Gaffer::PathFilter>' being compiled
- Use `check_call` functionality of properly escaping arguments to avoid problem with spaces in Inkscape path.
- `universal_newlines` offers better handling of encoding, and a clearer path to using the `text` argument when Python 2 support is dropped.
- On Windows, subprocess can't modify `PATH` using `env` - See Warning about locating the executable. https://docs.python.org/3/library/subprocess.html#popen-constructor
- The `INSTALL` override used on Windows for installing symlinked files can only handle files, not directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.