This repository has been archived by the owner on Aug 14, 2023. It is now read-only.
added provisioner support #376
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually this is an interesting idea. I know some of us over at @Daplanet was looking to switch over to podman in the on going LTS support fork for this project but using this idea allows one to specify which container tech to use or even open up for bare metal. I'll look further into this since it would also require some modifications to hypriot/flash as well. But +1 for the idea. |
|
I drafted a change there as well to allow updating the image with arbitrary confit files. https://github.com/hypriot/flash/pull/185/files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to know if the project would be interested in this change. I am testing a few different cluster variants and I wanted to take advantage of the Hypriot image but I wanted to swap out docker for k3s. To facilitate this, I broke out the docker installation into a provisioner folder and moved the installation code into this directory.
This change will let end-users add custom provisioners and set the provisioner by setting the PROVISIONER environment variable.