Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: package: replace sdbus-cpp with sdbus-cpp_2 (closes #286) #287

Merged

Conversation

spikespaz
Copy link
Contributor

@spikespaz spikespaz commented Oct 28, 2024

Replace XDPH's package argument sdbus-cpp with sdbus-cpp_2.

This is my less preferred option.

Let's discuss in #286.

Also see #288.

This PR should be merged over that one in the event that sdbus-cpp_2 is a permanent addition to Nixpkgs (and sdbus-cpp stays for dependents on 1.5.x).


Original:

In the default overlay, override XDPH's package arguments to say that sdbus-cpp = sdbus-cpp_2 which was introduced in a prior commit.

Let's discuss in #286.

This PR is my preference, until we do more digging in Nixpkgs to see if sdbus-cpp_2 is a permanent name, or if they're phasing it out once other package updates are merged.

See comments in code. This change to prevent conflicts for other
packages depending on `sdbus-cpp` in `pkgs`.
@spikespaz
Copy link
Contributor Author

cc @fufexan

@fufexan fufexan merged commit 33da30c into hyprwm:master Oct 28, 2024
1 check passed
@spikespaz spikespaz changed the title nix: overlays: xdph: override sdbus with sdbus-cpp_2 (closes #286) nix: package: replace sdbus-cpp with sdbus-cpp_2 (closes #286) Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants