-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/simplify consumers #1016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/simplify-consumers-2
branch
from
September 4, 2024 06:42
ed6a27e
to
6002560
Compare
gecBurton
force-pushed
the
feature/simplify-consumers-2
branch
2 times, most recently
from
September 4, 2024 07:46
7be4152
to
6002560
Compare
gecBurton
force-pushed
the
feature/simplify-consumers-2
branch
2 times, most recently
from
September 4, 2024 09:29
7f250d8
to
a6e3466
Compare
rachaelcodes
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
KevinEtchells
pushed a commit
that referenced
this pull request
Sep 6, 2024
* simplified handle_documents * wip * format * wip --------- Co-authored-by: George Burton <g.e.c.cburton@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As an Engineer I want to make use of the async ORM where reasonable
Changes proposed in this pull request
Guidance to review
Relevant links
Things to check
https://github.com/i-dot-ai/redbox/actions/runs/10698126327 a6e3466