Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/remove core api #1020

Merged
merged 25 commits into from
Sep 6, 2024
Merged

Feature/remove core api #1020

merged 25 commits into from
Sep 6, 2024

Conversation

gecBurton
Copy link
Collaborator

@gecBurton gecBurton commented Sep 4, 2024 •
edited
Loading

Context

As an Engineer I want to call the redbox-core directly from django so that i can remove an unnecessary service

Changes proposed in this pull request

  • core-api deleted
  • core-api removed from infra
  • all envvar and secrets merged in infra
  • no need for clearing space on github runner - integration tests now run in 5 mins

Guidance to review

Relevant links

Things to check

@gecBurton gecBurton marked this pull request as draft September 4, 2024 11:03
@gecBurton gecBurton marked this pull request as ready for review September 6, 2024 09:56
wpfl-dbt
wpfl-dbt reviewed Sep 6, 2024
View reviewed changes
.github/workflows/ai.yml Outdated Show resolved Hide resolved
jamesrichards4
jamesrichards4 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@jamesrichards4 jamesrichards4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand the django tests tbh but I'll look into that. Looks good to me though

wpfl-dbt
wpfl-dbt approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@wpfl-dbt wpfl-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks

@gecBurton @wpfl-dbt
Update django_app/tests/test_consumers.py
1b23a89 
Co-authored-by: Will Langdale <113046391+wpfl-dbt@users.noreply.github.com>
@gecBurton gecBurton merged commit bb3d5cf into main Sep 6, 2024
12 checks passed
@gecBurton gecBurton deleted the feature/remove-core-api branch September 6, 2024 12:05
KevinEtchells pushed a commit that referenced this pull request Sep 6, 2024
@gecBurton @KevinEtchells
Feature/remove core api (#1020)
9a72d2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpfl-dbt wpfl-dbt wpfl-dbt approved these changes

@jamesrichards4 jamesrichards4 jamesrichards4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gecBurton @jamesrichards4 @wpfl-dbt