Fixed settings to unstructured to make largest chunks the proper size #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Refactored loaders now they're so similar to make the whole setup simpler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Our 'largest' chunk resolution had no chunking and so were very small. This returns them to being the proper size
Changes proposed in this pull request
Use a single configurable document loader for all chunk resolutions. This uses chunk_by_title and sets the min and max chunk sizes to ensure we get the configured sizes.
Guidance to review
We probably want to add a new env var for largest_min_chunk_size at some point and there are improvements coming to the actual numbers. This PR just addresses the regression and a refactor which makes sense with this new config
Things to check