feature/opensearch #1114
Merged
feature/opensearch #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gecBurton
force-pushed
the
feature/opensearch
branch
from
1153c2b
to
d41d9a2
Compare
gecBurton
commented
Oct 22, 2024
| @@ -49,8 +49,7 @@ locals { | |||
| } | |||
|
|
|||
| django_app_secrets = { | |||
| "ELASTIC__API_KEY" : var.elastic_api_key, | |||
| "ELASTIC__CLOUD_ID" : var.cloud_id, | |||
| "ELASTIC__COLLECTION_ENDPOINT": module.opensearch.collection_enpdoint, | |||
There was a problem hiding this comment.
v nasty abuse of terminology here, suggestions welcome
There was a problem hiding this comment.
im not going to change this as this would introduce a breaking change to us, DBT and DSIT which isnt worth the effort for a non production feature
gecBurton
commented
Oct 22, 2024
| ) | ||
| client = OpenSearch( | ||
| hosts=[{"host": self.collection_enpdoint, "port": 443}], | ||
| http_auth=auth, |
There was a problem hiding this comment.
not sure this is needed from within VPC, still investigating
gecBurton
commented
Oct 22, 2024
infrastructure/aws/iam.tf
Outdated
| "aoss:*", | ||
| "es:*", | ||
| ] | ||
| resources = ["*"] |
There was a problem hiding this comment.
ok for testing, I will tighten
gecBurton
force-pushed
the
feature/opensearch
branch
from
5794a92
to
e8c2c16
Compare
gecBurton
commented
Oct 22, 2024
| # statement { | ||
| # effect = "Allow" | ||
| # actions = ["aoss:*"] | ||
| # resources = ["*"] restrict this |
There was a problem hiding this comment.
252afh
approved these changes
Oct 22, 2024
README.md
Outdated
|
|
||
| We are currently using ElasticSearch as our vector database. | ||
|
|
||
| We have also successfully deployed Redbox to OpenSearch Serverless but this support shouldbe considered experimental |
gecBurton
commented
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As an Infra Engineer I would like the option of being able to use OpenSearch instead of ElasticSearch as my vector database
Changes proposed in this pull request
Guidance to review
Note that this is POC only, and this is made clear in the README
This can be deployed and tested to dev
Relevant links
Things to check