Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/graph-time-scales #1115

Merged
merged 5 commits into from
Oct 22, 2024
Merged

feature/graph-time-scales #1115

merged 5 commits into from
Oct 22, 2024

Conversation

gecBurton
Copy link
Collaborator

@gecBurton gecBurton commented Oct 21, 2024

Context

As an Admin I want to be able to see user metrics per week/day/hour not just per day

Changes proposed in this pull request

  1. it is now possible to change the timescale of the graph, via a drop-down "select time scale", see picture
  2. a small bug fix as been fixed so that the model name rather than integer id is displayed

image

Guidance to review

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@gecBurton gecBurton marked this pull request as draft October 21, 2024 08:35
@gecBurton gecBurton changed the title feature/grpah-time-scales feature/graph-time-scales Oct 21, 2024
@@ -53,7 +63,7 @@
id="breakdown",
options=[
{"label": "route", "value": "route"},
{"label": "model", "value": "chat__chat_backend"},
{"label": "model", "value": "chat__chat_backend__name"},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug fix, chat__chat_backend used to be a string now its a foreign key to the LLM model

@gecBurton gecBurton marked this pull request as ready for review October 21, 2024 15:51
Copy link
Contributor

@KevinEtchells KevinEtchells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Longer-term it'd be good to think about the accessibility of this page more, though I appreciate we may go in a different direction before then anyway.

@gecBurton gecBurton merged commit bbe5233 into main Oct 22, 2024
6 checks passed
@gecBurton gecBurton deleted the feature/add-timescales-to-graph branch October 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants