Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add govuk search #1117

Merged
merged 20 commits into from
Oct 29, 2024
Merged

Feature/add govuk search #1117

merged 20 commits into from
Oct 29, 2024

Conversation

MarkDunne
Copy link
Contributor

@MarkDunne MarkDunne commented Oct 22, 2024

Context

We want to add functionality to search https://www.gov.uk/ into the agentic workflow

Changes proposed in this pull request

  • Builds on the wikipedia toolchain
  • Adds gov.uk search tool

image

Guidance to review

Useful way to check it is by asking for travel advice to cuba

Relevant links

Search API documentation - https://docs.publishing.service.gov.uk/repos/search-api.html

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@jamesrichards4
Copy link
Contributor

Sorry for being so slow on this. The approach looks good just wondering if we have different ruff settings somehow? It looks like there's some reformatting happening? Are you running make format or doing something else?

Not sure what's happening with the conflicts, probably just because we changed a lot while this branch was out?

@MarkDunne
Copy link
Contributor Author

MarkDunne commented Oct 29, 2024

Sorry for being so slow on this. The approach looks good just wondering if we have different ruff settings somehow? It looks like there's some reformatting happening? Are you running make format or doing something else?

Not sure what's happening with the conflicts, probably just because we changed a lot while this branch was out?

@jamesrichards4 Not really sure what is happening with the formatting. I did have some pending format changes before you reviewed, but even after using make format it suggested a few changes

@MarkDunne MarkDunne marked this pull request as ready for review October 29, 2024 11:29
@@ -218,7 +216,7 @@ def save_ai_message(
url=citation_source.source,
text=citation_source.highlighted_text_in_source,
page_numbers=citation_source.page_numbers,
source=Citation.Origin(citation_source.source_type.title()),
source=Citation.Origin(citation_source.source_type),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this comes from an enum now, we don't need to do any .title() stuff

Copy link
Collaborator

@gecBurton gecBurton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gecBurton gecBurton merged commit ebb45e4 into main Oct 29, 2024
6 checks passed
@gecBurton gecBurton deleted the feature/add-govuk-search branch October 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants