-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add govuk search #1117
Feature/add govuk search #1117
Conversation
Sorry for being so slow on this. The approach looks good just wondering if we have different ruff settings somehow? It looks like there's some reformatting happening? Are you running make format or doing something else? Not sure what's happening with the conflicts, probably just because we changed a lot while this branch was out? |
@jamesrichards4 Not really sure what is happening with the formatting. I did have some pending format changes before you reviewed, but even after using |
django_app/redbox_app/redbox_core/migrations/0059_merge_20241029_1135.py
Outdated
Show resolved
Hide resolved
@@ -218,7 +216,7 @@ def save_ai_message( | |||
url=citation_source.source, | |||
text=citation_source.highlighted_text_in_source, | |||
page_numbers=citation_source.page_numbers, | |||
source=Citation.Origin(citation_source.source_type.title()), | |||
source=Citation.Origin(citation_source.source_type), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this comes from an enum now, we don't need to do any .title()
stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
We want to add functionality to search https://www.gov.uk/ into the agentic workflow
Changes proposed in this pull request
Guidance to review
Useful way to check it is by asking for travel advice to cuba
Relevant links
Search API documentation - https://docs.publishing.service.gov.uk/repos/search-api.html
Things to check