Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show external citations #1125

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Show external citations #1125

merged 3 commits into from
Oct 24, 2024

Conversation

KevinEtchells
Copy link
Contributor

@KevinEtchells KevinEtchells commented Oct 24, 2024

Context

Updating the UI to show external citations.

Changes proposed in this pull request

Use the existing UI that we use for internal citations. No significant visual changes.

Guidance to review

  • Use @gadget to create some external citations. Check the links work and that the citations page displays okay
  • Use a document to create some internal citations. Check the links work and that the citations page displays okay

Relevant links

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

Remove superfluous function calls
@KevinEtchells KevinEtchells marked this pull request as ready for review October 24, 2024 11:07
@@ -32,6 +32,10 @@ HEARTBEAT_INTERNAL_PASSWORD=redboxpass
MONITORING_INTERNAL_PASSWORD=redboxpass
BEATS_SYSTEM_PASSWORD=redboxpass

# === Embedding ===
EMBEDDING_MODEL=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@KevinEtchells KevinEtchells merged commit d46a78e into main Oct 24, 2024
16 of 17 checks passed
@KevinEtchells KevinEtchells deleted the feature/external-citations-ui branch October 24, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants