Feature/streaming with citations #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
feature/citation_prompt has turned off streaming for citation responses temporarily. This restores it.
This PR should wait until the db migration fix PR has gone in. There should be no issues either way though
Changes proposed in this pull request
A custom PydanticOutputParser which streams tokens from the answer field of our citation response class while maintaining the creation of the pydantic object which tracks the answer and citations
Guidance to review
Enjoy. The work is mostly based on the existing Langchain output parsers with the relevant _transform functions overridden to allow stateful tracking of the token deltas.
Things to check