Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken filenames #1153

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix broken filenames #1153

merged 1 commit into from
Oct 31, 2024

Conversation

gecBurton
Copy link
Collaborator

Context

As an Admin I want a quick fix to be able to view Files

Changes proposed in this pull request

rather than raise a ValueError the file_name now logs the error and returns the full file name

Guidance to review

Relevant links

https://incubator-for-ai.sentry.io/issues/10896727/?alert_rule_id=41345&alert_timestamp=1730384758135&alert_type=email&environment=redbox-prod&notification_uuid=0af6f1ed-2a30-4b77-8aec-efee693ed29e&project=4507651065512016&referrer=alert_email

Things to check

  • I have added any new ENV vars in all deployed environments
  • I have tested any code added or changed
  • I have run integration tests

@gecBurton gecBurton merged commit f8228f6 into main Oct 31, 2024
6 checks passed
@gecBurton gecBurton deleted the bugfix/work-around-broken-filenames branch October 31, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants