Activities are collecting across messages #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinEtchells
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Activity Events are collecting across chat messages leading to all previous events attached to the latest ai message
Changes proposed in this pull request
Reset the activities list to empty on receive
Guidance to review
Is this the right fix for the issue? I'm definitely seeing previous activities on chat messages in preprod and this feels like we're building up all events in a websocket session?
Be good to revisit this long running consumer at some point too; for some of the interruptible/user prompting features we might want soon we need a single instance of the redbox graph (rather than per consumer).
Relevant links
Things to check