Feature/composable prompts #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rompt to not conflict with format instructions
gecBurton
reviewed
Nov 7, 2024
gecBurton
reviewed
Nov 7, 2024
| ) | ||
| # Set the system prompt to be our composed structure | ||
| # We preserve the format instructions | ||
| system_prompt_message = f""" |
gecBurton
approved these changes
Nov 7, 2024
Co-authored-by: George Burton <8233643+gecBurton@users.noreply.github.com>
…ox into feature/composable-prompts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Managing prompts is becoming a mess, we want to be able to store common information across prompts and to be able to reliably pass format information in without conflicting
Changes proposed in this pull request
Refactor all prompts to be just the task information, no system or format info should be provided. These are brought in from standard prompts system_info, persona_info, caller_info and format_instructions from the task if passed
NOTE: We want to do an additional piece of work here which is to redo the way we build AISettings each request to only use a set of sparse overrides from the db if created. That way we would always be using the default prompts from the settings unless we override them specifically in a deployment
Things to check