bugfix/allow metadata to fail #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saisakul
reviewed
Nov 13, 2024
| try: | ||
| metadata = self.create_file_metadata(first_thousand_words, original_metadata=original_metadata) | ||
| except TypeError: | ||
| metadata = GeneratedMetadata(name=original_metadata.get("filename")) |
There was a problem hiding this comment.
Does original_metadata always have filename? maybe add
metadata = GeneratedMetadata(name=original_metadata.get("filename", ""))
There was a problem hiding this comment.
its not guaranteed but it is the most likely https://docs.unstructured.io/api-reference/api-services/document-elements#common-metadata-fields
saisakul
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As a User i want my file to be ingested even if the generation of metadata fails so that i can use my data
Changes proposed in this pull request
Guidance to review
Relevant links
Things to check