Skip to content

Commit

Permalink
Fix the type of the components props of Trans. (#1036)
Browse files Browse the repository at this point in the history
  • Loading branch information
pcorpet authored and rosskevin committed Jan 10, 2020
1 parent 0b734b9 commit 04374c7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface TransProps<E extends Element = HTMLDivElement>
extends React.HTMLProps<E>,
Partial<WithT> {
children?: React.ReactNode;
components?: React.ReactNode[];
components?: readonly React.ReactNode[];
count?: number;
defaults?: string;
i18n?: i18n;
Expand Down
5 changes: 5 additions & 0 deletions test/typescript/Trans.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@ function components() {
return <Trans components={[<div />]}>Foo</Trans>;
}

function constComponents() {
const constArray = [<div />] as const;
return <Trans components={constArray}>Foo</Trans>;
}

function count() {
return <Trans count={42}>Foo</Trans>;
}
Expand Down

0 comments on commit 04374c7

Please sign in to comment.