Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpolation of the count prop doesn't work correctly in the Trans component #1719

Closed
timwest612 opened this issue Feb 6, 2024 · 2 comments

Comments

@timwest612
Copy link

🐛 Bug Report

When passing the count prop to a Trans component (with no values prop) the interpolation prefix/suffix change from the default to #$? & ?$#

Including an empty values object in the Trans prop makes it work fine (shown in the example).
I'm trying to pinpoint exactly in which version this broke as I noticed it when running a host of upgrades. I'll keep digging but thought I'd put this ticket up sooner rather than later in case it's an obvious fix that I'm missing!

I think it is a similar issue this? #1685

To Reproduce

A Link to codesandbox

Expected behavior

The interpolation for count passed directly as props should be the same as the rest of the i18next behaviour

adrai added a commit that referenced this issue Feb 6, 2024
@adrai
Copy link
Member

adrai commented Feb 6, 2024

v14.0.4 should address this

@timwest612
Copy link
Author

@adrai Amazing! Thanks so much, updated and all looks good 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants