-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples/v9.x.x not running #1786
Comments
Those examples seem to all be in the v9.x.x branch. Should we just delete them from the master branch to get rid of the vulnerability alerts? |
Yes, we can delete them, but maybe we need to change a link in the gitbook repo to target the old branch... |
I see what you mean. It seems the v9 links were broken already because they are pointing to the new examples. I'll raise a PR |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
I was doing some repo work when I came across this vulnerability report:
When I tried to fix it I realised that none of the projects in
example/v9.x.x/
seem to run. They throw aTypeError: fsevents is not a constructor
from chokidar.npm install
updates the lockfile but I wouldn't expect it to break.To Reproduce
cd examples/preact && npm install && npm run start
Expected behavior
I expected the examples to run.
Your Environment
The text was updated successfully, but these errors were encountered: