Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/v9.x.x not running #1786

Closed
ripecosta opened this issue Aug 13, 2024 · 3 comments · Fixed by #1787
Closed

examples/v9.x.x not running #1786

ripecosta opened this issue Aug 13, 2024 · 3 comments · Fixed by #1787

Comments

@ripecosta
Copy link
Contributor

🐛 Bug Report

I was doing some repo work when I came across this vulnerability report:
image

When I tried to fix it I realised that none of the projects in example/v9.x.x/ seem to run. They throw a TypeError: fsevents is not a constructor from chokidar.

npm install updates the lockfile but I wouldn't expect it to break.

To Reproduce

  • Clone the repo
  • Run cd examples/preact && npm install && npm run start

Expected behavior

I expected the examples to run.

Your Environment

  • runtime version: Node v20
  • i18next version: 8.4.3
  • os: Mac
  • npm version: 10.7.0
@ripecosta
Copy link
Contributor Author

Those examples seem to all be in the v9.x.x branch. Should we just delete them from the master branch to get rid of the vulnerability alerts?

@adrai
Copy link
Member

adrai commented Aug 13, 2024

Yes, we can delete them, but maybe we need to change a link in the gitbook repo to target the old branch...

@ripecosta
Copy link
Contributor Author

ripecosta commented Aug 13, 2024

I see what you mean. It seems the v9 links were broken already because they are pointing to the new examples. I'll raise a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants