Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove example/v9.x.x code #1787

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

ripecosta
Copy link
Contributor

Description

Removes all the examples/v9.x.x code. They are triggering security alerts (like this one) and are already backed up in the v9.x.x branch.

Fixes #1786

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteCI
Install scripts npm/core-js@3.21.1
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
🚫
Install scripts npm/core-js-pure@3.21.1
  • Install script: postinstall
  • Source: node -e "try{require('./postinstall')}catch(e){}"
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/core-js@3.21.1
  • @SocketSecurity ignore npm/core-js-pure@3.21.1

@coveralls
Copy link

Coverage Status

coverage: 97.094%. remained the same
when pulling c227c01 on ripecosta:rc/rm-example-v9
into 2f96833 on i18next:master.

@adrai adrai merged commit 6dcfcd6 into i18next:master Aug 13, 2024
8 of 9 checks passed
@ripecosta ripecosta deleted the rc/rm-example-v9 branch August 13, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples/v9.x.x not running
3 participants