Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comply with react strict mode #594

Closed
JimmyLaurent opened this issue Oct 30, 2018 · 4 comments
Closed

Comply with react strict mode #594

JimmyLaurent opened this issue Oct 30, 2018 · 4 comments

Comments

@JimmyLaurent
Copy link

React strict mode complains about the use of "componentWillReceiveProps" in "I18nextProvider".

Can we can replace it with "getDerivedStateFromProps" as suggested by the warnings ?

Thanks

@jamuhl
Copy link
Member

jamuhl commented Oct 30, 2018

Sure...are you open for a PR? Else i will add the change in the next version. Guess not to urgent to get patched.

@JimmyLaurent
Copy link
Author

Done.

I had to mirror the i18n prop in the state, though.

And you're right, it's not urgent.

@jamuhl
Copy link
Member

jamuhl commented Oct 30, 2018

Thank you...will take a look later today

@jamuhl
Copy link
Member

jamuhl commented Nov 8, 2018

should be solved with 022b9aa

published on npm in react-i18next@8.3.6

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project -> there are many ways to help this project 🙏

@jamuhl jamuhl closed this as completed Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants