Comply with react strict mode #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th "getDerivedStateFromProps"
1 similar comment
|
As it's only to show a warning if someone actively replaces the i18n instance - what do you think of dropping that warning? makes it simpler - and that warning i don't know how many people run into this honestly? |
|
I totally agree, it feels like an edge case. Do you want a new PR ? |
|
If you like and not takes to much time...else i will just remove it next time i got it open. |
|
should be solved with 022b9aa published on npm in react-i18next@8.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "componentWillReceiveProps" with "getDerivedStateFromProps" in "I18nextProvider".
Fixes: #594