Store should be initialized after useSSR #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a the store is initialized with data from Server side rendering, it fire these warnings anyway: `i18next was not initialized... This means something IS WRONG in your application setup.` However, the application setup is fine, the warning is inconsistent. I think this PR will do the trick: i18n should be considered as initialize once it receive initialI18nStore datas.
|
seems correct -> published in react-i18next@11.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a the store is initialized with data from Server side rendering, it fire these warnings anyway:
i18next was not initialized... This means something IS WRONG in your application setup.However, the application setup is fine, the warning is inconsistent.
I think this PR will do the trick: i18n should be considered as initialize once it receive initialI18nStore datas.